From 24a38d1c5a7e7f4911e1a95b35e95ea334827c3c Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 18 May 2019 16:38:48 +0200 Subject: [PATCH] WatchedItemStore: Remove deprecated Title param to getNextRevision() This was deprecated in I76bc6fd6ee, but somehow this usage was missed, maybe the commit that added it went through review in parallel with that one. Change-Id: I8131f360f4300f62d56be64fda117038f51e693b --- includes/watcheditem/WatchedItemStore.php | 2 +- .../phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/watcheditem/WatchedItemStore.php b/includes/watcheditem/WatchedItemStore.php index ec25002d9c..85606247a0 100644 --- a/includes/watcheditem/WatchedItemStore.php +++ b/includes/watcheditem/WatchedItemStore.php @@ -1120,7 +1120,7 @@ class WatchedItemStore implements WatchedItemStoreInterface, StatsdAwareInterfac } $oldRev = $this->revisionLookup->getRevisionById( $oldid ); - $nextRev = $this->revisionLookup->getNextRevision( $oldRev, $title ); + $nextRev = $this->revisionLookup->getNextRevision( $oldRev ); if ( !$nextRev ) { // Oldid given and is the latest revision for this title; clear the timestamp. return null; diff --git a/tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php b/tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php index 82308de4ea..7ec2d373b3 100644 --- a/tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php +++ b/tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php @@ -2094,9 +2094,8 @@ class WatchedItemStoreUnitTest extends MediaWikiTestCase { return $mockRevisionRecord; }, 'getNextRevision' => - function ( $oldRev, $titleArg ) use ( $mockRevisionRecord, $title ) { + function ( $oldRev ) use ( $mockRevisionRecord ) { $this->assertSame( $mockRevisionRecord, $oldRev ); - $this->assertSame( $title, $titleArg ); return false; }, ], [ -- 2.20.1